fix overwritten issue for pull and periodic html#328
Open
ArthurChenCoding wants to merge 2 commits intocloud-bulldozer:mainfrom
Open
fix overwritten issue for pull and periodic html#328ArthurChenCoding wants to merge 2 commits intocloud-bulldozer:mainfrom
ArthurChenCoding wants to merge 2 commits intocloud-bulldozer:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ArthurChenCoding
force-pushed
the
main
branch
2 times, most recently
from
8b1fb62 to
cf137d2
Compare
Signed-off-by: ArthurChenCoding <artchen@redhat.com>
Signed-off-by: ArthurChenCoding <artchen@redhat.com>
mohit-sheth
requested review from
chentex
and removed request for
mcornea and
venkataanil
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
When --pr-analysis --viz are both enabled, both pull and periodic figures are generated, but pull is overwritten by periodic as the generated HTML file has the same name. Hence, the HTML file only contains the periodic figure.
Fix:
Add a suffix to the file name according to the type of run
Result(test):
For a query like this:
orion \ --config examples/trt-external-payload-node-density.yaml \ --hunter-analyze \ --pr-analysis \ --input-vars '{"version":"4.22","jobtype":"pull","pull_number":"2975","organization":"openshift","repository":"ovn-kubernetes"}' \ --benchmark-index 'ripsaw-kube-burner-*' \ --metadata-index 'perf_scale_ci*' \ --lookback 15d \ --save-output-path pr2975.txt \ --vizWill result in these 2 files: